Closed Bug 1549485 Opened 6 years ago Closed 6 years ago

[meta] Performance.disable

Categories

(Remote Protocol :: CDP, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 67

People

(Reporter: ato, Unassigned)

References

()

Details

(Keywords: meta, Whiteboard: [method=Performance.disable])

No description provided.
Blocks: puppeteer
Keywords: meta
Whiteboard: [method=Performance.disable]

The basics for this method have been implemented for the remote protocol, which simply sets the internal flag to disabled. Maybe that is all what we should do here, and simply close this bug? Or shall we wait until the necessary event listeners have been removed?

Andreas, what is your take on that?

Flags: needinfo?(ato)

Oh, and Puppeteer doesn't use this method at all. Instead it leaks all the registered event listeners for each and every instance of the Page class. So it's nothing we would need for the alpha release.

Depends on: 1533682
Flags: needinfo?(ato)

As discussed with Andreas we have the implementation done for Performance.disable() and this CDP endpoint can be called. Handling (registering, unregistering) of events will be handled on their own meta bugs.

The implementation was done for Firefox 67 on bug 1533682.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Component: CDP: Performance → CDP
You need to log in before you can comment on or make changes to this bug.